speedie/spmenu
2
0
Fork 1
Code Issues 1 Pull requests Packages Projects Releases 15 Wiki Activity

clean up warnings when -Ofast is used

Browse source 
it may still segfault, im not sure
This commit is contained in:
speedie 2023-05-08 22:44:27 +02:00
parent eb7a68f7ea
commit fc8d12cd0a
2 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
libs/stream.c
View file

@ -72,9 +72,9 @@ void readfile(void) {
static size_t c = 0;
char *l;
FILE *ef = fopen(listfile, "r");
FILE *lf = fopen(listfile, "r");
if (!ef) return;
if (!lf) return;
items = NULL;
listsize = 0;
@ -83,8 +83,8 @@ void readfile(void) {
l = NULL;
len = 0;
if (-1 == getline(&l, &len, ef)) {
if (ferror(ef)) die("spmenu: failed to read file\n");
if (-1 == getline(&l, &len, lf)) {
if (ferror(lf)) die("spmenu: failed to read file\n");
free(l);
break;
}
@ -100,7 +100,7 @@ void readfile(void) {
listsize++;
}
if (fclose(ef)) {
if (fclose(lf)) {
die("spmenu: failed to close file %s\n", listfile);
}
@ -190,7 +190,7 @@ int parsemarkup(int index) {
#endif
/* TODO: use this for something
* current usage is not very useful, however it's here to be used later.
* current usage is not very uslful, however it's here to be used later.
*/
if(!(items[index].ex = malloc(strlen(items[index].text)+1)))
fprintf(stderr, "spmenu: cannot malloc %lu bytes\n", strlen(items[index].text));

2
spmenu.c
View file

@ -440,7 +440,7 @@ void insert(const char *str, ssize_t n) {
memmove(&text[cursor + n], &text[cursor], sizeof text - cursor - MAX(n, 0));
// update cursor
if (n > 0)
if (n > 0 && str && n)
memcpy(&text[cursor], str, n);
// add to cursor position and continue matching